Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: component code validation #3470

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

This pull request refactors the code validation process for the component. It includes the following changes:

  • Used the validate component code on generic node code validation.

  • Removed an unused console log.

  • Used post validate code mutation on component code.

  • Added post validate component code mutation.

  • Removed post custom component update.

These changes improve the code validation process and ensure that the component code is properly validated.

@lucaseduoli lucaseduoli self-assigned this Aug 21, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 21, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 21 Aug 24 13:57 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 21, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3470.dmtpw4p5recq1.amplifyapp.com

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) August 21, 2024 14:20
@Cristhianzl Cristhianzl merged commit 1d46bee into main Aug 21, 2024
20 checks passed
@Cristhianzl Cristhianzl deleted the refactor-post-custom-component branch August 21, 2024 14:47
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
* removed post custom component update

* Added post validade component code mutation

* Used post validade code mutation on component code

* removed unused console log

* used validate component code on generic node code validation
ogabrielluiz pushed a commit that referenced this pull request Aug 27, 2024
* removed post custom component update

* Added post validade component code mutation

* Used post validade code mutation on component code

* removed unused console log

* used validate component code on generic node code validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants