-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow setting temperature to 0 in OpenAIModel.py #3465
Conversation
As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 21 Aug 24 06:43 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update OpenAIModel.py- Fix can not set temperature to 0 bug. As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
Update OpenAIModel.py- Fix can not set temperature to 0 bug. As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.