Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting temperature to 0 in OpenAIModel.py #3465

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

maxpaynebupt
Copy link
Contributor

As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.

As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 21, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 21 Aug 24 06:43 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3465.dmtpw4p5recq1.amplifyapp.com

@maxpaynebupt maxpaynebupt changed the title Update OpenAIModel.py- Fix can not set temperature to 0 bug. Fix:Can not set temperature to 0 bug in OpenAIModel.py Aug 21, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
@ogabrielluiz ogabrielluiz changed the title Fix:Can not set temperature to 0 bug in OpenAIModel.py fix : allow setting temperature to 0 in OpenAIModel.py Aug 21, 2024
@ogabrielluiz ogabrielluiz changed the title fix : allow setting temperature to 0 in OpenAIModel.py fix: allow setting temperature to 0 in OpenAIModel.py Aug 21, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 21, 2024 19:05
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 21, 2024
@ogabrielluiz ogabrielluiz merged commit 5ffaa78 into langflow-ai:main Aug 21, 2024
48 of 51 checks passed
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
Update OpenAIModel.py- Fix can not set temperature to 0 bug.

As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
ogabrielluiz pushed a commit that referenced this pull request Aug 27, 2024
Update OpenAIModel.py- Fix can not set temperature to 0 bug.

As when the input temperature is 0, the condition would become False , so this expressing set it to 0.1, it become impossible to set it to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants