Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: API JS generated code #3461

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

Yukiyukiyeah
Copy link
Collaborator

@Yukiyukiyeah Yukiyukiyeah commented Aug 20, 2024

JS API generated code currently cannot support user defined parameters, and lacks "input_type, output_type" arguments as Python and Curl do.
Besides, the output code is too redundant. It will output too many repeated errors. It also lacks the detailed error message like Python code.
In this PR I added the user defined parameters and missing arguments, also simplify the output.

To run the JS code:
node <YOUR_FILE_NAME>.js [user_message] [input_type] [output_type] [stream]

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Aug 20, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 20 Aug 24 23:39 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3461.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yukiyukiyeah

Welcome!

Thanks for your contribution.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
@ogabrielluiz ogabrielluiz merged commit dde0fa4 into langflow-ai:main Aug 22, 2024
26 of 27 checks passed
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
* update js code

* fix langflowid

* fix code change
ogabrielluiz pushed a commit that referenced this pull request Aug 27, 2024
* update js code

* fix langflowid

* fix code change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants