Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update type extraction to extract inner types correctly #3446

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 20, 2024

This PR updates the post_process_type function to extract inner types of inner types.

This mainly fixes an error in which extra types were passed in the component's output leading to invalid handles.

#3445

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 20, 2024
@ogabrielluiz ogabrielluiz changed the title update-post-process-type-logic fix: update type extraction to extract inner types correctly Aug 20, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 20 Aug 24 12:26 UTC

@github-actions github-actions bot added the bug Something isn't working label Aug 20, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 20, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3446.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 20, 2024 12:46
@ogabrielluiz ogabrielluiz merged commit 037c090 into main Aug 20, 2024
35 of 36 checks passed
@ogabrielluiz ogabrielluiz deleted the update-post-process-type-logic branch August 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge between Component and CrewAIAgentComponent has invalid handles - HELP
2 participants