-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: moves caching of vector store to LCModelComponent level #3435
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 19 Aug 24 19:44 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanrfrazier
Very nice implementation.
Is this focused on making sure the document is never added more than once in a single build?
@ogabrielluiz that's correct, yes. Though I also think we should give users the option to generate deterministic ID's from the content, but that can be implemented after. |
8ed1e00
to
9dd9fc5
Compare
c7349dc
to
2fc3ec9
Compare
* refactor LCModelComponent to use a cached vector store to prevent multiple embeddings
* refactor LCModelComponent to use a cached vector store to prevent multiple embeddings
Prevents multiple
build_vector_store
calls from embedding the input multiple times.Closes #3376