Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds credentials fields in Vectara RAG component #3396

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

david-oplatka
Copy link
Contributor

@ogabrielluiz Thanks for your guidance on updating the Vectara RAG component. I believe I have made all of the necessary changes to fix the component. Please review when you have a moment. Thanks again!

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Aug 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 16 Aug 24 19:44 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3396.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @david-oplatka

Thanks for the update!

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 16, 2024
@ogabrielluiz ogabrielluiz changed the title Bug Fixes for Vectara RAG fix: adds credentials fields in Vectara RAG component Aug 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 16, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 16, 2024 19:59
@ogabrielluiz ogabrielluiz merged commit b0619f5 into langflow-ai:main Aug 16, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants