Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makes outputs be correctly retrieved from edge #3392

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 16, 2024

This adds a target_handle_name param to get_result so edges can be correctly selected when getting result.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request title does not follow the desired pattern

Last Modified at 16 Aug 24 18:21 UTC

@ogabrielluiz ogabrielluiz changed the title update-get-result-method-params fix: makes outputs be correctly retrieved from edge Aug 16, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 16, 2024
@ogabrielluiz ogabrielluiz linked an issue Aug 16, 2024 that may be closed by this pull request
@ogabrielluiz ogabrielluiz force-pushed the update-get-result-method-params branch from ac8b47c to 0b2a07e Compare August 16, 2024 18:22
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 16, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 16, 2024 18:23
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3392.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz force-pushed the update-get-result-method-params branch 2 times, most recently from 2d0e4a3 to 2848f6c Compare August 16, 2024 18:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 16, 2024
@ogabrielluiz ogabrielluiz merged commit 16afd44 into main Aug 16, 2024
44 of 45 checks passed
@ogabrielluiz ogabrielluiz deleted the update-get-result-method-params branch August 16, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputs get mixed up
2 participants