Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove json_mode and output_schema #3385

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

vasconceloscezar
Copy link
Collaborator

@vasconceloscezar vasconceloscezar commented Aug 16, 2024

This PR removes the json_mode and output_schema parameters from the AIMLModel component. The changes include:

  1. Removal of the json_mode Dictionary from the component definition.
  2. Removal of the output_schema Dictionary from the component definition.
  3. Deletion of the json_mode variable assignment in the build_model method.
  4. Removal of the output_schema_dict variable and its usage in the build_model method.

These changes simplify the AIMLModel component by removing unused or redundant features. The PR aligns with issue #3385, which called for the removal of these parameters.

Importantly, this PR fixes errors related to unsupported features in AI ML. Specifically, it addresses the error:
"Error building Component Tool Calling Agent: AsyncCompletions.create() got an unexpected keyword argument 'json_mode'"

This error occurs because the AI ML component does not support the json_mode parameter, and removing it resolves this issue.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 16, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request title does not follow the desired pattern

Last Modified at 16 Aug 24 15:01 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3385.dmtpw4p5recq1.amplifyapp.com

@vasconceloscezar vasconceloscezar changed the title fix:: remove json_mode and output_schema fix: remove json_mode and output_schema Aug 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 19, 2024
@ogabrielluiz ogabrielluiz merged commit 5181fd8 into main Aug 19, 2024
38 of 39 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/aiml-model-params branch August 19, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants