Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test to stop building feature #3364

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

Cristhianzl
Copy link
Collaborator

@Cristhianzl Cristhianzl commented Aug 15, 2024

  • This PR introduces a new test that verifies the behavior of the UI when the building is in two different states: running and stopped.

✨ (use-icons-status.tsx): Add data-testid attribute to Loading component for testing purposes
✨ (index.tsx): Add data-testid attribute to stop building button for testing purposes
✨ (stop-building.spec.ts): Add end-to-end test to ensure user can stop a building process

…ent for testing purposes

✨ (index.tsx): Add data-testid attribute to stop building button for testing purposes
✨ (stop-building.spec.ts): Add end-to-end test to ensure user can stop a building process
@Cristhianzl Cristhianzl self-assigned this Aug 15, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 15, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 15 Aug 24 18:30 UTC

@Cristhianzl Cristhianzl changed the title tests: add test to freeze component feature tests: add test to stop building feature Aug 15, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3364.dmtpw4p5recq1.amplifyapp.com

…n stop a building process successfully and verify the button functionality.
@Cristhianzl Cristhianzl removed the request for review from ogabrielluiz August 16, 2024 14:01
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anovazzi1 anovazzi1 self-requested a review August 16, 2024 20:09
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 16, 2024
@Cristhianzl Cristhianzl merged commit c03677c into main Aug 19, 2024
37 of 44 checks passed
@Cristhianzl Cristhianzl deleted the cz/testStopBuilding branch August 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants