Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor report merge step to only run if necessary. #3361

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 15, 2024

This adds a condition to skip merge-reports job if there was no error in the frontend tests

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 15, 2024
@ogabrielluiz ogabrielluiz added the lgtm This PR has been approved by a maintainer label Aug 15, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 15 Aug 24 12:49 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3361.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz force-pushed the skip-merge-reports-if-tests-successful branch from b19a2d7 to 488d974 Compare August 15, 2024 13:01
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 15, 2024 13:02
@ogabrielluiz ogabrielluiz force-pushed the skip-merge-reports-if-tests-successful branch from 488d974 to 211e1c3 Compare August 15, 2024 13:50
@ogabrielluiz ogabrielluiz disabled auto-merge August 15, 2024 15:54
@ogabrielluiz ogabrielluiz merged commit 450ebb7 into main Aug 15, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the skip-merge-reports-if-tests-successful branch August 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant