Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve store and collection card components #3350

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request refactors the store card components by adding a new card store component, using the StoreCardComponent for displaying store cards, and removing unused code. Additionally, the Collection card has been updated to fit only the my collection case.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 14, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 14 Aug 24 21:09 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 14, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3350.dmtpw4p5recq1.amplifyapp.com

@anovazzi1 anovazzi1 merged commit 981f314 into main Aug 14, 2024
36 of 37 checks passed
@anovazzi1 anovazzi1 deleted the refactorCardComponent branch August 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants