Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add ComponentTextModal and Prompt modal for displaying and editing text areas and components #3346

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request adds a new component called ComponentTextModal, which is used for displaying and editing text areas. The ComponentTextModal includes a textarea input, a title, and an icon, and supports password visibility toggling. It is used within a BaseModal component and includes a save button for finishing the editing process. This pull request also includes refactoring changes to rename the promptAreaModal to promptModal and update the type import, update the promptComponent to use PromptModal instead of GenericModal, and update the textarea-primary class in applies.css. Additionally, the genericModal component and its references are deleted.

Add a new component, ComponentTextModal, for displaying and editing text areas. This component includes a textarea input, a title, and an icon. It also supports password visibility toggling. The ComponentTextModal is used within a BaseModal component and includes a save button for finishing the editing process. This commit refactors the code to add the ComponentTextModal and its related functionality.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 14, 2024
@dosubot dosubot bot added enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 14 Aug 24 17:51 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3346.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@anovazzi1 anovazzi1 changed the title Add ComponentTextModal and Prompt modal for displaying and editing text areas and components refactor: Add ComponentTextModal and Prompt modal for displaying and editing text areas and components Aug 14, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Aug 14, 2024
@anovazzi1 anovazzi1 merged commit e5ee0ba into main Aug 14, 2024
38 of 39 checks passed
@anovazzi1 anovazzi1 deleted the refactorGenericModal branch August 14, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants