Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get result from output if possible #3338

Merged
merged 17 commits into from
Aug 15, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 14, 2024

This PR also refactors _build_params

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request title does not follow the desired pattern

Last Modified at 14 Aug 24 13:22 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3338.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz changed the title set-params-from-normal-edge-fix feat: get result from output if possible Aug 14, 2024
@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working labels Aug 14, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the refactor-extract-method-to-set-params-from-edge branch from a0de196 to 6e7ba4c Compare August 14, 2024 14:27
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the refactor-extract-method-to-set-params-from-edge branch from 6e7ba4c to 70371b9 Compare August 14, 2024 16:53
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 14, 2024 18:40
@ogabrielluiz ogabrielluiz force-pushed the refactor-extract-method-to-set-params-from-edge branch from 2cad966 to fecf109 Compare August 14, 2024 18:46
@ogabrielluiz ogabrielluiz force-pushed the refactor-extract-method-to-set-params-from-edge branch from 1c86d00 to 1b464d5 Compare August 15, 2024 15:33
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 15, 2024
@ogabrielluiz ogabrielluiz merged commit 2baee5f into main Aug 15, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor-extract-method-to-set-params-from-edge branch August 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants