Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not mark self.stop caller #3335

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 14, 2024

This PR makes sure the vertex that calls Graph.mark_branch does not get marked with the rest of the branch.
Also refactors the mark_branch method into a private method.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 14 Aug 24 12:59 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3335.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix-do-not-mark-self.stop-caller branch 2 times, most recently from 79e216c to 9de1f56 Compare August 14, 2024 18:11
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 14, 2024 18:11
@ogabrielluiz ogabrielluiz merged commit a90cb12 into main Aug 14, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-do-not-mark-self.stop-caller branch August 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants