Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update output attribute handling #3329

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 14, 2024

Adds outputs to getattr which helps access to outputs.
Refactors _build_results to for consistency

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels Aug 14, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 14 Aug 24 12:20 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3329.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat-update-output-attribute-handling branch from aaaedd9 to 7bcc152 Compare August 14, 2024 14:34
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat-update-output-attribute-handling branch from 7bcc152 to 662202e Compare August 14, 2024 18:11
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 14, 2024 18:23
@ogabrielluiz ogabrielluiz force-pushed the feat-update-output-attribute-handling branch 4 times, most recently from d341182 to 1150f51 Compare August 14, 2024 21:54
@ogabrielluiz ogabrielluiz force-pushed the feat-update-output-attribute-handling branch from 1150f51 to 5e98c67 Compare August 15, 2024 11:27
Copy link
Contributor

Detected 14 changes to dependencies in Poetry lockfile

Updated anthropic (0.33.1 -> 0.34.0)
Updated astra-assistants (2.0.23 -> 2.0.24)
Updated boto3 (1.34.159 -> 1.34.161)
Updated botocore (1.34.159 -> 1.34.161)
Updated elasticsearch (8.14.0 -> 8.15.0)
Updated google-api-python-client (2.140.0 -> 2.141.0)
Updated google-cloud-aiplatform (1.61.0 -> 1.62.0)
Updated importlib-resources (6.4.0 -> 6.4.2)
Updated langchain-anthropic (0.1.22 -> 0.1.23)
Updated litellm (1.43.9 -> 1.43.13)
Updated nltk (3.8.2 -> 3.8.1)
Updated postgrest (0.16.9 -> 0.16.10)
Updated pyright (1.1.375 -> 1.1.376)
Updated setuptools (72.1.0 -> 72.2.0)

(0 added, 0 removed, 14 updated, 464 not changed)

@ogabrielluiz ogabrielluiz force-pushed the feat-update-output-attribute-handling branch from 3c0d624 to 245df6d Compare August 15, 2024 11:59
@ogabrielluiz ogabrielluiz merged commit bb923cf into main Aug 15, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the feat-update-output-attribute-handling branch August 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants