Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adds new tests for new variable service #3306

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

italojohnny
Copy link
Member

adds two new tests for the new delete_variable_by_id method to improve test coverage

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 13, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 13 Aug 24 13:53 UTC

@github-actions github-actions bot added the test Changes to tests label Aug 13, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3306.dmtpw4p5recq1.amplifyapp.com

@italojohnny italojohnny force-pushed the refactor/global_variables branch from 1971bb1 to febf52c Compare August 13, 2024 14:00
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 13, 2024 17:55
@ogabrielluiz ogabrielluiz merged commit 4f5dca8 into main Aug 13, 2024
57 of 65 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor/global_variables branch August 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. test Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants