Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: lock psycopg to 3.1.19 #3292

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Conversation

jordanrfrazier
Copy link
Collaborator

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 12, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 12 Aug 24 21:31 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3292.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 12, 2024 21:37
@@ -49,8 +49,7 @@ pinecone-client = "^3.0.3"
pymongo = "^4.6.0"
supabase = "^2.3.0"
certifi = ">=2023.11.17,<2025.0.0"
psycopg = "^3.1.9"
psycopg-binary = "^3.1.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this causes an error, I think. That's why it was two separate declarations

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both (as well as psycopg2)? I see that the full source is recommended for production, whereas the binary is meant for easy builds and testing purposes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I remember we had both for a reason, I just can't remember what it was

@jordanrfrazier jordanrfrazier force-pushed the psycopg-version-lock-to-3.1.19 branch from e0c2fe1 to c79fec6 Compare August 13, 2024 15:31
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Detected 6 changes to dependencies in Poetry lockfile

Removed psycopg-binary (3.2.1)
Removed psycopg2-binary (2.9.9)
Updated langwatch (0.1.19 -> 0.1.20)
Updated psycopg (3.2.1 -> 3.1.9)
Updated sentry-sdk (2.12.0 -> 2.13.0)
Updated soupsieve (2.5 -> 2.6)

(0 added, 2 removed, 4 updated, 473 not changed)

@jordanrfrazier jordanrfrazier force-pushed the psycopg-version-lock-to-3.1.19 branch from f78c0e0 to 7dc44cf Compare August 13, 2024 16:06
@ogabrielluiz ogabrielluiz merged commit 120786f into main Aug 13, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the psycopg-version-lock-to-3.1.19 branch August 13, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac can not install psycopg-binary==3.2.1 (MAC 13.5.1 (22G90) M1)
2 participants