-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep: lock psycopg to 3.1.19 #3292
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 12 Aug 24 21:31 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@@ -49,8 +49,7 @@ pinecone-client = "^3.0.3" | |||
pymongo = "^4.6.0" | |||
supabase = "^2.3.0" | |||
certifi = ">=2023.11.17,<2025.0.0" | |||
psycopg = "^3.1.9" | |||
psycopg-binary = "^3.1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this causes an error, I think. That's why it was two separate declarations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both (as well as psycopg2)? I see that the full source is recommended for production, whereas the binary is meant for easy builds and testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. I remember we had both for a reason, I just can't remember what it was
e0c2fe1
to
c79fec6
Compare
Detected 6 changes to dependencies in Poetry lockfileRemoved psycopg-binary (3.2.1) (0 added, 2 removed, 4 updated, 473 not changed) |
f78c0e0
to
7dc44cf
Compare
See psycopg/psycopg#858
Closes #2600