Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected URI handling in SQLDatabaseComponent #3291

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

carlosrcoelho
Copy link
Contributor

  • Changed import from langchain_experimental.sql.base.SQLDatabase to langchain_community.utilities.sql_database.SQLDatabase
  • Updated build method to create an SQLAlchemy engine with StaticPool for better connection management
  • Removed clean_up_uri method as it's no longer needed

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Aug 12, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3291.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 12, 2024 21:40
@ogabrielluiz ogabrielluiz merged commit dc419d1 into main Aug 12, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the sqlDatabase-component branch August 12, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants