Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update parameters in spider components #3280

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: update parameters in spider components #3280

merged 3 commits into from
Aug 12, 2024

Conversation

WilliamEspegren
Copy link
Contributor

Upgrade spider-client and make it functional

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 10, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3280.dmtpw4p5recq1.amplifyapp.com

@WilliamEspegren WilliamEspegren changed the title Fix spider fix: spider Aug 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2024
ogabrielluiz
ogabrielluiz approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @WilliamEspegren

Thanks for the fix!

Could you improve the PR title, please?

LGTM otherwise

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
@ogabrielluiz ogabrielluiz changed the title fix: spider fix: update parameters in spider components Aug 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 12, 2024 16:27
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 12, 2024
@WilliamEspegren
Copy link
Contributor Author

Hey @ogabrielluiz!

Thank you for changing the PR title. I am innocent of the tests that are failing right?

Let me know if I should do something :)

@ogabrielluiz ogabrielluiz merged commit e09f157 into langflow-ai:main Aug 12, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilliamEspegren @ogabrielluiz