Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct issue with The "No suitable component" error is appearing on the OpenAI component and other components due to a missing check #3279

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

deekshanee
Copy link
Contributor

Issue is attached here -

#3272

Bug Description
We have noticed that a check is missing when displaying edge dots on the left side of the component. As a result, an unnecessary dot appears, causing confusion for users.

Reproduction

Open Langflow.
Click on "Add New Project."
Select the "Basic Prompting" template.
You'll notice that the OpenAI node displays an unused edge dot on the left side.

Screen.Recording.2024-08-10.at.4.10.31.AM.mov

Expected behaviour

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 10, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 10 Aug 24 16:17 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 10, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3279.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli self-requested a review August 11, 2024 00:01
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 11, 2024
@deekshanee
Copy link
Contributor Author

hi @lucaseduoli please merge this pr to avoid merge conflicts

@lucaseduoli lucaseduoli merged commit 1789e2d into langflow-ai:main Aug 11, 2024
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants