Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic state model creation and update #3271

Merged
merged 27 commits into from
Aug 13, 2024
Merged

Conversation

ogabrielluiz
Copy link
Contributor

This pull request includes several refactorings and feature additions to the Component class in the custom_component module. The visibility of the method _get_output_by_method has been changed to public by renaming it to get_output_by_method, improving accessibility and clarity. Additionally, state model management has been implemented with lazy initialization and dynamic instance getter in the custom_component class. The _reset_all_output_values method has been added to initialize component outputs. The Graph class has been enhanced with lazy loading for state model creation from the graph, and a new method create_state_model_from_graph has been added to the graph state_model module. Unit tests and functional tests have been added to validate the state model creation and graph state update.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 09 Aug 24 22:05 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3271.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz changed the title feat: add dynamic state model creation and updates feat: add dynamic state model creation and update Aug 10, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 10, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 12, 2024
@ogabrielluiz ogabrielluiz force-pushed the feat/addstate branch 2 times, most recently from 5016132 to fb82107 Compare August 12, 2024 18:53
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
Refactor the Component class in the custom_component module to change the visibility of the method `_get_output_by_method` to public by renaming it to `get_output_by_method`. This change improves the accessibility and clarity of the method for external use.
…er utilities in state model to ensure proper structure
… improved method integrity in state model handling
…rror handling for output methods in model.py
…to improve clarity on functionality and usage scenarios
….py to clarify functionality and usage examples
…e_model.py to clarify functionality and provide examples
@ogabrielluiz ogabrielluiz merged commit c5d9cba into main Aug 13, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/addstate branch August 13, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants