Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start using dev mode flag and add exception filter in logger #3260

Merged
merged 14 commits into from
Aug 9, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request adds a new settings module with a development mode flag and helper functions for setting the development state. It also enhances the logger module with development mode handling and a TypedDict for log configuration settings. The Settings class is updated to include the development mode flag and an associated validator for enhanced configuration management. Additionally, a logging init module is created for improved logger configuration and management. The logger import path is updated to align with recent module restructuring, and the logger module is reorganized. A setup.py file is added for logging configuration.

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 9, 2024 12:07
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 09 Aug 24 12:08 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 9, 2024
@ogabrielluiz ogabrielluiz changed the title feat: add development mode flag and enhance logger configuration feat: start using development mode flag and enhance logger Aug 9, 2024
@ogabrielluiz ogabrielluiz changed the title feat: start using development mode flag and enhance logger feat: start using dev mode flag and add exception filter in logger Aug 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3260.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2024
@dosubot dosubot bot removed the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 9, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 9, 2024
…g_extensions for better type hinting support
@ogabrielluiz ogabrielluiz merged commit 645c723 into main Aug 9, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/conditionalexceptionlog branch August 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants