Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add components for node name, description, and status #3248

Merged
merged 13 commits into from
Aug 13, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes several commits that refactor the codebase and add new components for managing node names, descriptions, and status. The repeated and unused code has been removed, and the input parameters in the GenericNode component have been sorted. Additionally, the NodeName component has been added for displaying and editing node names, the NodeDescription component has been added for displaying and editing node descriptions, and the NodeStatus component has been added for displaying and managing node status. These changes improve the overall organization and functionality of the codebase.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 8, 2024
@dosubot dosubot bot added enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 08 Aug 24 19:02 UTC

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed enhancement New feature or request labels Aug 8, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3248.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@anovazzi1 anovazzi1 merged commit 64aecdd into main Aug 13, 2024
29 of 30 checks passed
@anovazzi1 anovazzi1 deleted the refactorNode branch August 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants