-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and improved PythonCodeStructuredTool, SearXNGTool, and RunnableExecutor #3239
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 08 Aug 24 04:42 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
For RunnableExecutor, we are using LangChain's streaming attribute, which doesn't seem to be captured by the tracer since it is neither a callback nor an output parser. I would like to know the core team's opinion on separating this into a dedicated AgentStreamingExecutor. |
result_value, _status = self.get_output(result, self.input_key, self.output_key) | ||
status += _status | ||
status += f"\n\nOutput: {result_value}\n\nRaw Output: {result}" | ||
self.status = status | ||
return result_value | ||
|
||
async def astream_events(self, input): | ||
async for event in self.runnable.astream_events(input, version="v1"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you could do is use the callbacks's methods for each type of event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @goliath-yamon
Sorry for the other PR ^^"
The RunnableExectutor needs some work it seems but the others look good to me. Let me know if you want to split them up into different PRs.
Also, if you create a new branch on your fork, it is easier for us to make any fixes
…ically and accept global variables
…uredTool.py for clarity and consistency
…l.py for improved readability and type safety
…uild method to asynchronous.
Hey @ogabrielluiz Thank you for your answer. Yes, if you can split them, do that please :) After this, I will create a new branch to fix any issues or create any features. |
PythonCodeStructuredTool
SearXNGTool
RunnableExecutor