-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve NodeOutputField and NodeInputField components #3235
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 07 Aug 24 21:38 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove console logs
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Refactored the NodeOutputField component in the GenericNode file to improve code organization and readability. Also refactored the NodeInputField component in the GenericNode file to remove unnecessary code and improve performance. These changes enhance the overall maintainability and efficiency of the codebase.