Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: prevent esc on codeAreaModal #3232

Merged
merged 8 commits into from
Aug 13, 2024
Merged

enhancement: prevent esc on codeAreaModal #3232

merged 8 commits into from
Aug 13, 2024

Conversation

anovazzi1
Copy link
Contributor

@anovazzi1 anovazzi1 commented Aug 7, 2024

improve usability of the code editor
#3188

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 07 Aug 24 20:02 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3232.dmtpw4p5recq1.amplifyapp.com

@anovazzi1 anovazzi1 requested a review from lucaseduoli August 7, 2024 20:07
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 13, 2024 12:18
@ogabrielluiz ogabrielluiz merged commit 6658426 into main Aug 13, 2024
31 checks passed
@ogabrielluiz ogabrielluiz deleted the preventEsc branch August 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants