Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement graph combination method #3224

Merged
merged 134 commits into from
Aug 7, 2024
Merged

feat: Implement graph combination method #3224

merged 134 commits into from
Aug 7, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request adds new methods and functionality to the Graph class for combining vertices and edges from other graph instances. It includes commits that validate graph combination, call the initialize method for proper setup, extend serialization to include additional attributes, and implement addition methods for combining vertices and edges. The pull request also includes git patches that modify the Edge and Graph classes to add new attributes and update the add and initialize methods. Additionally, there are unit tests that validate the graph combination functionality.

…tries in types list for improved type management
… enhance robustness against JSON decode errors
…_type alias for clarity and consistency in field definitions
…input/output methods for better component interaction
…pe safety and structure in vertex data handling
- Consolidated imports and removed redundant `BaseModel` definitions for `SourceHandle` and `TargetHandle`.
- Added `valid_handles`, `target_param`, and `_target_handle` attributes to `Edge` class.
- Enhanced handle validation logic to distinguish between dictionary and string types.
- Introduced `to_data` method to return edge data.
- Updated attribute names to follow consistent naming conventions (`base_classes`, `input_types`, `field_name`).
…ge class

- Renamed attributes to use snake_case consistently (`baseClasses` to `base_classes`, `inputTypes` to `input_types`, `fieldName` to `field_name`).
- Added `to_data` method to return `_data` attribute.
- Updated validation methods to use new attribute names.
…utes and improve validation logic for handles
…thods to NodeData for better type safety and clarity
…d `dump` methods, enhancing data export capabilities
…est structure for better clarity and organization
- Added `getRightHandleId` function to generate the right handle ID for source handles.
- Added `getLeftHandleId` function to generate the left handle ID for target handles.
- These functions improve code readability and maintainability by encapsulating the logic for generating handle IDs.
…ocessing

- Replace usages of `fileData` with `parsedFlowData` for improved clarity
- Ensure compatibility with newProject and isComponent parameters
- Improve error handling for uploading components as flows or vice versa
- Refactor code for better readability and maintainability
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 07 Aug 24 13:08 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 7, 2024
Base automatically changed from feat/elkjslayout to main August 7, 2024 14:04
An error occurred while trying to automatically change base from feat/elkjslayout to main August 7, 2024 14:04
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@ogabrielluiz ogabrielluiz merged commit 22305fe into main Aug 7, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/dunderadd branch August 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants