-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement graph combination method #3224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Edge dictionaries
…tries in types list for improved type management
…d validation logic when checking data types
… enhance robustness against JSON decode errors
…_type alias for clarity and consistency in field definitions
…input/output methods for better component interaction
…pe safety and structure in vertex data handling
…hod for better data management and access
…nclude model_config attribute
- Consolidated imports and removed redundant `BaseModel` definitions for `SourceHandle` and `TargetHandle`. - Added `valid_handles`, `target_param`, and `_target_handle` attributes to `Edge` class. - Enhanced handle validation logic to distinguish between dictionary and string types. - Introduced `to_data` method to return edge data. - Updated attribute names to follow consistent naming conventions (`base_classes`, `input_types`, `field_name`).
…ge class - Renamed attributes to use snake_case consistently (`baseClasses` to `base_classes`, `inputTypes` to `input_types`, `fieldName` to `field_name`). - Added `to_data` method to return `_data` attribute. - Updated validation methods to use new attribute names.
…utes and improve validation logic for handles
…thods to NodeData for better type safety and clarity
…d `dump` methods, enhancing data export capabilities
…est structure for better clarity and organization
…ove test structure
…e code and improve readability
… code clarity and maintainability
- Added `getRightHandleId` function to generate the right handle ID for source handles. - Added `getLeftHandleId` function to generate the left handle ID for target handles. - These functions improve code readability and maintainability by encapsulating the logic for generating handle IDs.
…fety in reactflowUtils
…gement in reactflowUtils
…ng edge validation in reactflowUtils
…ut escaped handle IDs more effectively
…ocessing - Replace usages of `fileData` with `parsedFlowData` for improved clarity - Ensure compatibility with newProject and isComponent parameters - Improve error handling for uploading components as flows or vice versa - Refactor code for better readability and maintainability
…end node input field
…rsing in CodeParser tests
…ore RAG unit tests
…types in graph class
… test structure and readability
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 07 Aug 24 13:08 UTC |
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Aug 7, 2024
ogabrielluiz
force-pushed
the
feat/elkjslayout
branch
from
August 7, 2024 13:09
9429478
to
9ed053e
Compare
…anagerStore for cleaner codebase
… consistency in constants file
…k.json for cleaner dependency management
An error occurred while trying to automatically change base from
feat/elkjslayout
to
main
August 7, 2024 14:04
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Aug 7, 2024
italojohnny
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new methods and functionality to the Graph class for combining vertices and edges from other graph instances. It includes commits that validate graph combination, call the initialize method for proper setup, extend serialization to include additional attributes, and implement addition methods for combining vertices and edges. The pull request also includes git patches that modify the Edge and Graph classes to add new attributes and update the add and initialize methods. Additionally, there are unit tests that validate the graph combination functionality.