Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: parameterComponent in GenericNode #3220

Merged
merged 8 commits into from
Aug 7, 2024
Merged

refactor: parameterComponent in GenericNode #3220

merged 8 commits into from
Aug 7, 2024

Conversation

anovazzi1
Copy link
Contributor

this refactor deletes the parameter component and creates a NodeInputComponent and a NodeOutputComponent

@anovazzi1
refactor: create NodeOutputField component in GenericNode
da40080
@anovazzi1
feat: update isUserChange parameter in setNode function
8e70361 
The `isUserChange` parameter in the `setNode` function of the `FlowStoreType` interface has been updated to be optional. This change improves the flexibility and usability of the function.
@anovazzi1
feat: Add NodeInputField component to GenericNode
09fe676 
The NodeInputField component has been added to the GenericNode component. This component is responsible for rendering input fields for nodes in the UI. It improves the functionality and user experience of the GenericNode component.
@anovazzi1
delete parameter component
bc77bbf
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 6, 2024
@anovazzi1 anovazzi1 requested a review from lucaseduoli August 6, 2024 21:50
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅
Pull request has a valid title ✅ ❌

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 06 Aug 24 21:50 UTC

@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3220.dmtpw4p5recq1.amplifyapp.com

@anovazzi1 anovazzi1 changed the title Refactor parameter component in GenericNode refactor: parameterComponent in GenericNode Aug 6, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 6, 2024
lucaseduoli
lucaseduoli requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some suggestions for improvement. I'm aware the code has just been transfered from one component to two, but these changes should be easy to make and should make the code a lot more readable.

src/frontend/src/CustomNodes/GenericNode/components/NodeInputField/index.tsx Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeInputField/index.tsx Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx Outdated Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx Outdated Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx Show resolved Hide resolved
src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx Show resolved Hide resolved
@anovazzi1
feat: Refactor NodeOutputField component in GenericNode
6b906cb 
The NodeOutputField component in the GenericNode component has been refactored to improve code organization and maintainability. This refactor enhances the functionality and user experience of the GenericNode component.
@anovazzi1
Merge branch 'main' into refactorNodeInputOutput
23b5812
@lucaseduoli lucaseduoli self-requested a review August 7, 2024 14:22
lucaseduoli
lucaseduoli approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@anovazzi1 anovazzi1 merged commit e6d1b84 into main Aug 7, 2024
30 of 37 checks passed
@anovazzi1 anovazzi1 deleted the refactorNodeInputOutput branch August 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaseduoli lucaseduoli lucaseduoli approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anovazzi1 @lucaseduoli