Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate flow_name presence in flow components before retrieving flow data #3218

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 6, 2024

Added check to ensure flow_name is provided in attributes.

Fixed some other validation steps.

The code changes in `base.py` modify the `Vertex` class to handle the `Data` type. Specifically, it adds a condition to check if the value is an instance of `Data` and then unescapes the string using `val.get_text()`. This change improves the functionality and data management in the `Vertex` class.
Added a check to continue if the message_dict does not have a "text" field in the ComponentVertex class
Updated SubFlowComponent to ensure flow_name is fetched correctly from attributes before execution
Added a conditional check to ensure flow_name is provided in attributes
…ng flow data

Added check to ensure flow_name is provided in attributes
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 06 Aug 24 20:09 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 6, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3218.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) August 7, 2024 12:59
@lucaseduoli lucaseduoli linked an issue Aug 7, 2024 that may be closed by this pull request
@lucaseduoli lucaseduoli merged commit d44505f into main Aug 7, 2024
61 of 62 checks passed
@lucaseduoli lucaseduoli deleted the fix/flowcomponents branch August 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Flow as Tool component will crash, please fix it as a priority
2 participants