Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve metric creation logic and silence ot warnings #3207

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request refactors the metric creation logic in the opentelemetry.py file and improves the handling methods for metrics. It enhances warnings and ensures that the key in the mapping and metric's name are the same. Additionally, it simplifies the metric creation process by using a helper method _create_metric().

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 5, 2024 20:56
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 05 Aug 24 20:57 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3207.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz force-pushed the refactor/otwarnings branch 2 times, most recently from aa47aa6 to 7736601 Compare August 15, 2024 16:44
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2024
@ogabrielluiz ogabrielluiz merged commit 7e7d5a1 into main Aug 23, 2024
34 of 35 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor/otwarnings branch August 23, 2024 12:51
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
refactor(opentelemetry.py): enhance metric creation logic warnings and improved metric handling methods
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
refactor(opentelemetry.py): enhance metric creation logic warnings and improved metric handling methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants