Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance CustomComponent class and updates tests #3201

Merged
merged 12 commits into from
Aug 5, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Refactored the CustomComponent class to streamline initialization and removed unnecessary imports for better code clarity. Updated the user_id and flow_id parameters to use properties for better encapsulation and code clarity.

Refactored user_id and flow_id in CustomComponent to use properties for better encapsulation and code clarity
…orts

Refactored the CustomComponent class to streamline initialization and removed unnecessary import for BaseCallbackHandler
…or field order to improve consistency and clarity
…validation and error reporting in message.py
…e for consistency in test_custom_component.py
…g and custom fields in test_prompt_component.py
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 5, 2024 18:57
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 05 Aug 24 18:58 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3201.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 5, 2024
@ogabrielluiz ogabrielluiz merged commit f706b05 into main Aug 5, 2024
59 of 60 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/generalcomponentfixes branch August 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants