Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Branding and Social Links to the UI Feature flags #3169

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

mfortman11
Copy link
Collaborator

Now allows users to toggle on/off DataStax branding and Langflow social links

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Aug 2, 2024
@mfortman11 mfortman11 changed the title UI Feature flags: Add Branding and Social Links to the config feat: Add Branding and Social Links to the UI Feature flags Aug 2, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3169.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 02 Aug 24 14:34 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 2, 2024
@ogabrielluiz
Copy link
Contributor

Hey @mfortman11

How are you?

How does this work on pip install? Will these be added on the build step or will the user be able to change later as well?

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) August 6, 2024 18:21
@anovazzi1 anovazzi1 merged commit dedad1e into langflow-ai:main Aug 6, 2024
36 of 38 checks passed
@codenprogressive
Copy link

Hey @mfortman11

I was going to ask the same question as Ogabrielluiz.
How are we going to change those variables ENABLE_SOCIAL_LINKS and ENABLE_BRANDING ? Can we change them in the .env file https://github.com/langflow-ai/langflow/blob/main/.env.example?

@buntys2010
Copy link

@codenprogressive You can set this flags from src/frontend/src/customization/feature-flags.ts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants