feat: Add suggestion message to API exception response #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest updating the outdated components in the API exception handling. This commit adds a suggestion message to the API exception response when there are outdated components in the flow. The suggestion message provides the number of outdated components and recommends updating them. The suggestion is generated based on the list of outdated components obtained from the flow data.
dosubot
bot
added
the
size:M
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
requested changes
Aug 1, 2024
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
ogabrielluiz
requested changes
Aug 1, 2024
…ions.api Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
…w.api.utils and langflow.exceptions.api
ogabrielluiz
requested changes
Aug 5, 2024
…nd langflow.exceptions.api
ogabrielluiz
requested changes
Aug 5, 2024
| super().__init__(status_code=status_code, detail=body.model_dump_json()) | ||
|
|
||
| @staticmethod | ||
| def from_exc_and_flow(exc: str | list[str], flow: Flow) -> ExceptionBody: |
There was a problem hiding this comment.
The method needs a more descriptive name
Suggested change
| def from_exc_and_flow(exc: str | list[str], flow: Flow) -> ExceptionBody: | |
| def build_exception_body(exc: str | list[str], flow: Flow | None) -> ExceptionBody: |
Comment on lines
24
to
25
| if flow is None: | ||
| body = ExceptionBody(message=str(exception)) |
There was a problem hiding this comment.
The condition shouldn't be here. It could be inside the method, for example
Suggested change
| if flow is None: | |
| body = ExceptionBody(message=str(exception)) |
ogabrielluiz
requested changes
Aug 5, 2024
…components functions
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a suggestion message to the API exception response when there are outdated components in the flow. The suggestion message provides the number of outdated components and recommends updating them. The suggestion is generated based on the list of outdated components obtained from the flow data. Additionally, the code has been refactored to improve readability and maintainability.