-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: automatically refresh user's session #3148
Conversation
…piration time 🔧 (App.tsx): Add support for refreshing access token and setting expiration time 📝 (authAdminGuard/index.tsx): Remove unnecessary logout function and add conditional check for login page 📝 (authGuard/index.tsx): Add conditional check for login page 📝 (constants.ts): Add constants for access token expiration time 📝 (authContext.tsx): Remove logout function and update related logic 📝 (api.tsx): Add conditional check for login page 📝 (use-post-logout.ts): Remove navigate function call 📝 (LoginPage/index.tsx): Add logic to reset flows and selected folder on successful login ✨ (LoginPage/index.tsx): Add support for managing folders in the login page to improve user experience 🔧 (authStore.ts): Update logout function to clear user data and redirect to login page for better security and user experience 📝 (contexts/auth.ts): Remove unnecessary logout function from AuthContextType for consistency 🔧 (vite.config.mts): Add environment variables for ACCESS_TOKEN_EXPIRE_SECONDS and CI to improve configuration flexibility
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 01 Aug 24 18:25 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#3130
#3132
📝 (App.tsx): Update imports and add new constants for access token expiration time
🔧 (App.tsx): Add support for refreshing access token and setting expiration time
📝 (authAdminGuard/index.tsx): Remove unnecessary logout function and add conditional check for login page
📝 (authGuard/index.tsx): Add conditional check for login page
📝 (constants.ts): Add constants for access token expiration time
📝 (authContext.tsx): Remove logout function and update related logic
📝 (api.tsx): Add conditional check for login page
📝 (use-post-logout.ts): Remove navigate function call
📝 (LoginPage/index.tsx): Add logic to reset flows and selected folder on successful login
✨ (LoginPage/index.tsx): Add support for managing folders in the login page to improve user experience
🔧 (authStore.ts): Update logout function to clear user data and redirect to login page for better security and user experience
📝 (contexts/auth.ts): Remove unnecessary logout function from AuthContextType for consistency
🔧 (vite.config.mts): Add environment variables for ACCESS_TOKEN_EXPIRE_SECONDS and CI to improve configuration flexibility