Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set sqlite pragma by env variable #3136

Merged
merged 5 commits into from
Aug 1, 2024
Merged

feat: set sqlite pragma by env variable #3136

merged 5 commits into from
Aug 1, 2024

Conversation

zzzming
Copy link
Collaborator

@zzzming zzzming commented Aug 1, 2024

SQLite Pragma should not be hardcoded. This PR introduce an env variable to all these PRAGMA statement to be configurable without code changes.

To change the pragams you can set the env variable LANGFLOW_SQLITE_PRAGMAS using a JSON dict

The default value is unchanged and is

LANGFLOW_SQLITE_PRAGMAS="{"synchronous": "NORMAL", "journal_mode": "WAL"}"

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 01 Aug 24 01:50 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 1, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3136.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 1, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
@nicoloboschi nicoloboschi enabled auto-merge (squash) August 1, 2024 12:46
@nicoloboschi nicoloboschi merged commit 1dd840c into main Aug 1, 2024
51 checks passed
@nicoloboschi nicoloboschi deleted the feat/sqlite-cfg branch August 1, 2024 12:48
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
* set sqlite pragma by env variable

* configurable

* [autofix.ci] apply automated fixes

* fix circular dep

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Nicolò Boschi <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
(cherry picked from commit 1dd840c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants