-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add useQuery management on globalVariables CRUD #3121
Conversation
… data 🔧 (addNewVariableButton.tsx): Replace registerGlobalVariable function with usePostGlobalVariables hook for adding new global variables 🔧 (inputGlobalComponent/index.tsx): Replace deleteGlobalVariable function with useDeleteGlobalVariables hook for deleting global variables 🔧 (authContext.tsx): Remove unused getGlobalVariables function and setGlobalVariables state from authContext 🔧 (constants.ts): Add VARIABLES constant for global variables endpoint 🔧 (index.ts): Remove getGlobalVariables, registerGlobalVariable, and deleteGlobalVariable functions from API index ✨ (variables/index.ts): Add use-delete-global-variables hook for deleting global variables 🔧 (use-delete-global-variables.ts): Implement useDeleteGlobalVariables hook for deleting global variables ✨ (use-get-global-variables.ts): Add functionality to fetch and set global variables from API ✨ (use-patch-global-variables.ts): Add functionality to update global variables via API patch request ✨ (use-post-global-variables.ts): Add functionality to create new global variables via API post request 📝 (index.tsx): Import useGetGlobalVariables hook to fetch global variables on login page 📝 (index.tsx): Call mutateGetGlobalVariables function to fetch global variables on successful login 📝 (index.tsx): Import useDeleteGlobalVariables hook to delete global variables on global variables page 📝 (index.tsx): Call mutateDeleteGlobalVariable function to delete selected global variables 📝 (index.tsx): Handle success and error cases for deleting global variables
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 31 Jul 24 17:44 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request will change globalVariables CRUD to use useQuery.
✨ (App.tsx): Add useGetGlobalVariables hook to fetch global variables data
🔧 (addNeVariableButton.tsx): Replace registerGlobalVariable function with usePostGlobalVariables hook for adding new global variables
🔧 (inputGlobalComponent/index.tsx): Replace deleteGlobalVariable function with useDeleteGlobalVariables hook for deleting global variables
🔧 (authContext.tsx): Remove unused getGlobalVariables function and setGlobalVariables state from authContext
🔧 (constants.ts): Add VARIABLES constant for global variables endpoint
🔧 (index.ts): Remove getGlobalVariables, registerGlobalVariable, and deleteGlobalVariable functions from API index
✨ (variables/index.ts): Add use-delete-global-variables hook for deleting global variables
🔧 (use-delete-global-variables.ts): Implement useDeleteGlobalVariables hook for deleting global variables
✨ (use-get-global-variables.ts): Add functionality to fetch and set global variables from API
✨ (use-patch-global-variables.ts): Add functionality to update global variables via API patch request
✨ (use-post-global-variables.ts): Add functionality to create new global variables via API post request
📝 (index.tsx): Import useGetGlobalVariables hook to fetch global variables on login page
📝 (index.tsx): Call mutateGetGlobalVariables function to fetch global variables on successful login
📝 (index.tsx): Import useDeleteGlobalVariables hook to delete global variables on global variables page
📝 (index.tsx): Call mutateDeleteGlobalVariable function to delete selected global variables
📝 (index.tsx): Handle success and error cases for deleting global variables