Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text input jumps to the end of the text after writing one letter #3090

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: text input jumps to the end of the text after writing one letter #3090

merged 1 commit into from
Jul 30, 2024

Conversation

lucaseduoli
Copy link
Collaborator

  • Added UseMemo for the component to not re-render and lose cursor position

@lucaseduoli lucaseduoli linked an issue Jul 30, 2024 that may be closed by this pull request
Text input jumps to the end of the text after writing one letter #3058
Closed
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 30, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 30, 2024 20:06
@dosubot dosubot bot added bug Something isn't working javascript Pull requests that update Javascript code labels Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 30 Jul 24 20:06 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 30, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3090.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli self-assigned this Jul 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@lucaseduoli lucaseduoli merged commit 6a1f185 into main Jul 30, 2024
45 of 47 checks passed
@lucaseduoli lucaseduoli deleted the 3058-text-input-jumps-to-the-end-of-the-text-after-writing-one-letter branch July 30, 2024 21:34
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
@lucaseduoli @nicoloboschi
fix: text input jumps to the end of the text after writing one letter (…
815c207 
…langflow-ai#3090)

Fixed not being able to write in the middle of the component

(cherry picked from commit 6a1f185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees

@lucaseduoli lucaseduoli

Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text input jumps to the end of the text after writing one letter
2 participants
@lucaseduoli @ogabrielluiz