fix: dropdown and multiselect component values on disabled and option text not truncating #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when combobox is true
…own when combobox is true
dosubot
bot
added
size:L
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 30 Jul 24 19:50 UTC |
github-actions
bot
added
bug
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ogabrielluiz
approved these changes
Jul 30, 2024
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Aug 1, 2024
… text not truncating (langflow-ai#3089) * Fixed dropdown component showing empty value and not showing dropdown when combobox is true * Fixed multiselect component showing empty value and not showing dropdown when combobox is true * Added disabled onChange on multiline and dropdown, with snapshot ignore * Fixed tooltip skip delay duration that made tooltip on Dropdown unusable * Fixed size of text inside dropdown and multiselect --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> (cherry picked from commit 1336ae0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several fixes for the dropdown and multiselect components:
Fixed an issue where the dropdown component was showing an empty value and not displaying the dropdown when the combobox option was set to true.
Fixed a similar issue with the multiselect component.
Added a disabled onChange event for the multiline and dropdown components, with snapshot ignore.
Fixed the tooltip skip delay duration that was making the tooltip on the dropdown component unusable.
Fixed the size of the text inside the dropdown and multiselect components.
These changes address the reported issues and improve the functionality and usability of the components.