Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: check if user exists before create a new refresh token #3076

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

Cristhianzl
Copy link
Collaborator

@Cristhianzl Cristhianzl commented Jul 30, 2024

This pull request introduces a new validation step before creating a new refresh token. Additionally, improvements have been made to the interceptor functionality.

Changes:

  • User Existence Check:

Added a check to verify if the user exists in the database before generating a new refresh token. This ensures that tokens are only created for valid users.

  • Interceptor Improvements:

Applied several enhancements to the interceptor to improve its performance and reliability.
#3130

@Cristhianzl Cristhianzl self-assigned this Jul 30, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working enhancement New feature or request labels Jul 30, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 30 Jul 24 15:57 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3076.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 31, 2024 16:38
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 31, 2024 17:58
@Cristhianzl Cristhianzl removed the request for review from ogabrielluiz July 31, 2024 17:58
@Cristhianzl Cristhianzl merged commit d7aed90 into main Jul 31, 2024
51 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix_refresh branch July 31, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants