Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endpoint /run api call could run same node twice #3062

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Jul 30, 2024

if a node has two predecessor and they end up in the same layer of execution, the node is executed twice. This can cause problems for idempotent nodes, such as message memory

Fixes #3028

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 30, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 30 Jul 24 08:53 UTC

@nicoloboschi nicoloboschi changed the title fix: /run api call could run same node twice fix: endpoint /run api call could run same node twice Jul 30, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3062.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 30, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 30, 2024 14:07
@ogabrielluiz ogabrielluiz merged commit 91da7f7 into langflow-ai:main Jul 30, 2024
68 of 71 checks passed
@nicoloboschi nicoloboschi deleted the api-run-twice branch July 30, 2024 14:23
nicoloboschi added a commit to datastax/ragstack-ai-langflow that referenced this pull request Aug 1, 2024
fix: /run api call could run same node twice
(cherry picked from commit 91da7f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Store Message" duplicates human messages, but only on API call (not Playground)
2 participants