-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: add steps to delete flows caused by new constraints #3045
Conversation
…ability and efficiency ✨ (use-delete-flows.ts): add useDeleteFlows hook to handle deletion of multiple flows in frontend ♻️ (index.tsx): refactor handleDeleteMultiple function to use useDeleteFlows hook for deleting multiple flows 🔧 (actionsMainPage-shard-1.spec.ts): add test for selecting and deleting a flow in end-to-end tests
…e and improve readability ♻️ (flows.py): Refactor code to remove unnecessary import and variable declarations, making the code more concise and maintainable
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 29 Jul 24 21:12 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
…-ai#3045) * 📝 (flows.py): refactor delete_multiple_flows function to improve readability and efficiency ✨ (use-delete-flows.ts): add useDeleteFlows hook to handle deletion of multiple flows in frontend ♻️ (index.tsx): refactor handleDeleteMultiple function to use useDeleteFlows hook for deleting multiple flows 🔧 (actionsMainPage-shard-1.spec.ts): add test for selecting and deleting a flow in end-to-end tests * 📝 (flows.py): Remove unused imports and variables to clean up the code and improve readability ♻️ (flows.py): Refactor code to remove unnecessary import and variable declarations, making the code more concise and maintainable * add unit tests to delete multiple flows with transactions and build * format * add assert on tests (cherry picked from commit c2b5b98)
📝 (flows.py): refactor delete_multiple_flows function to improve readability and efficiency
✨ (use-delete-flows.ts): add useDeleteFlows hook to handle deletion of multiple flows in frontend
♻️ (index.tsx): refactor handleDeleteMultiple function to use useDeleteFlows hook for deleting multiple flows
🔧 (actionsMainPage-shard-1.spec.ts): add test for selecting and deleting a flow in end-to-end tests
📝 (flows.py): Remove unused imports and variables to clean up the code and improve readability
♻️ (flows.py): Refactor code to remove unnecessary import and variable declarations, making the code more concise and maintainable