Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for custom component message storage #3042

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ogabrielluiz
Copy link
Contributor

The code changes in types.py add support for storing messages in custom components. If a custom component has the attributes should_store_message and store_message, the store_message method will be called to store the message. This enhancement improves the functionality of the interface vertex in the graph.

The code changes in `types.py` add support for storing messages in custom components. If a custom component has the attributes `should_store_message` and `store_message`, the `store_message` method will be called to store the message. This enhancement improves the functionality of the interface vertex in the graph.
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 29, 2024 20:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jul 29, 2024
@ogabrielluiz ogabrielluiz changed the title feat: Add support for custom component message storage fix: add support for custom component message storage Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 20:06 UTC

@github-actions github-actions bot added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3042.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@ogabrielluiz ogabrielluiz merged commit 72a880d into main Jul 29, 2024
67 of 69 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/streamingchatmemory branch July 29, 2024 20:38
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* fix: remove create task call

* feat: Add support for custom component message storage

The code changes in `types.py` add support for storing messages in custom components. If a custom component has the attributes `should_store_message` and `store_message`, the `store_message` method will be called to store the message. This enhancement improves the functionality of the interface vertex in the graph.

(cherry picked from commit 72a880d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants