Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change login/auto_login to use UseQuery #3033

Merged
merged 21 commits into from
Jul 31, 2024
Merged

Conversation

Cristhianzl
Copy link
Member

✨ (App.tsx): Introduce framer-motion library for animations in the frontend
🔧 (App.tsx): Update import path for useAutoLogin function in controllers/API/queries/auth
🔧 (index.ts): Remove autoLogin function from API controllers as it is now handled by useAutoLogin hook
🔧 (use-get-autologin.ts): Update function name to useAutoLogin and adjust return type
🔧 (use-post-login-user.ts): Update function name to loginUserFn for clarity
🔧 (LoginPage/index.tsx): Update import path for useLoginUser function in controllers/API/queries/auth
🔧 (LoginPage/index.tsx): Update function name to loginUserFn for clarity
🔧 (authStore.ts): Remove unused imports and functions related to autoLogin and login operations

…ontend

🔧 (App.tsx): Update import path for useAutoLogin function in controllers/API/queries/auth
🔧 (index.ts): Remove autoLogin function from API controllers as it is now handled by useAutoLogin hook
🔧 (use-get-autologin.ts): Update function name to useAutoLogin and adjust return type
🔧 (use-post-login-user.ts): Update function name to loginUserFn for clarity
🔧 (LoginPage/index.tsx): Update import path for useLoginUser function in controllers/API/queries/auth
🔧 (LoginPage/index.tsx): Update function name to loginUserFn for clarity
🔧 (authStore.ts): Remove unused imports and functions related to autoLogin and login operations
@Cristhianzl Cristhianzl requested a review from anovazzi1 July 29, 2024 16:35
@Cristhianzl Cristhianzl self-assigned this Jul 29, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Jul 29, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 29 Jul 24 16:38 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3033.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jul 29, 2024
@Cristhianzl Cristhianzl requested a review from anovazzi1 July 29, 2024 22:19
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 29, 2024 22:19
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@Cristhianzl Cristhianzl disabled auto-merge July 30, 2024 17:12
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 30, 2024 17:12
@Cristhianzl Cristhianzl disabled auto-merge July 30, 2024 19:07
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 31, 2024 16:38
Cristhianzl and others added 6 commits July 31, 2024 14:44
…dling in the authentication process

📝 (authGuard/index.tsx): Import constant for auto login option and update logic to check for token before logging out
🔧 (constants.ts): Remove unused import to improve code cleanliness
🔧 (authContext.tsx): Refactor login and logout functions to use state setters directly for better code readability and maintainability
…er used

🔧 (use-get-profile-pictures.ts): Remove unused code related to fetching profile pictures
🔧 (use-preload-images.tsx): Refactor usePreloadImages hook to accept profilePictures as an argument
🔧 (profilePictureChooserComponent/index.tsx): Update usage of usePreloadImages hook to match new signature
🔧 (ProfilePictureForm/index.tsx): Refactor to use useGetProfilePicturesQuery hook instead of handleGetProfilePictures function
@Cristhianzl Cristhianzl merged commit 3835f8d into main Jul 31, 2024
51 checks passed
@Cristhianzl Cristhianzl deleted the refactor/login branch July 31, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants