Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flag to disable transaction and vertex_builds writes #3031

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Jul 29, 2024

Add setting to not write transactions or vertex_builds. Those option are useful for the UI but not for the runtime part.
Since they now are written to the SQL db, it's important to make them able to be disabled them to avoid useless writes and costs

Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

Last Modified at 29 Jul 24 15:58 UTC

@github-actions github-actions bot added the enhancement New feature or request label Jul 29, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3031.dmtpw4p5recq1.amplifyapp.com

@nicoloboschi nicoloboschi marked this pull request as ready for review July 30, 2024 07:19
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 30, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 7, 2024 19:21
@ogabrielluiz ogabrielluiz merged commit 56523a7 into langflow-ai:main Aug 7, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants