Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set a generic placeholder on float input #3015

Merged
merged 4 commits into from
Jul 29, 2024
Merged

refactor: set a generic placeholder on float input #3015

merged 4 commits into from
Jul 29, 2024

Conversation

igorrCarvalho
Copy link
Contributor

This pull request refactors the existing float input placeholder by using a more generic one.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Jul 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has a valid title ✅ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ✅

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 28 Jul 24 22:02 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jul 28, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3015.dmtpw4p5recq1.amplifyapp.com

lucaseduoli
lucaseduoli approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) July 29, 2024 22:15
anovazzi1
anovazzi1 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anovazzi1 anovazzi1 merged commit 0fcba55 into main Jul 29, 2024
31 checks passed
@anovazzi1 anovazzi1 deleted the fix/floatInputPlaceholder branch July 29, 2024 22:26
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
@igorrCarvalho @nicoloboschi
refactor: set a generic placeholder on float input (langflow-ai#3015)
17dfb81 
* fix: set a generic placeholder on the float input

* [autofix.ci] apply automated fixes

* refactor: remove unnecessary validation

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: anovazzi1 <[email protected]>
(cherry picked from commit 0fcba55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

@lucaseduoli lucaseduoli lucaseduoli approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorrCarvalho @lucaseduoli @anovazzi1