-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ctrl a not working on edit node table #2992
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 26 Jul 24 17:28 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…l with ctrl + A on advanced modal to ensure functionality works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* removed console log and fixed nulland * Fixed ag grid version mismatch * Fixed unused import * Fixed ctrl+a not working on edit node and tweaks * Fixed styling on editnode * Made it work on mac * ✅ (generalBugs-shard-7.spec.ts): add end-to-end test for selecting all with ctrl + A on advanced modal to ensure functionality works as expected --------- Co-authored-by: cristhianzl <[email protected]> (cherry picked from commit f7ad36b)
This pull request includes several fixes and updates to the codebase. The changes include:
Removed console log and fixed nulland
Fixed ag grid version mismatch
Fixed unused import
Fixed ctrl+a not working on edit node and tweaks
Fixed styling on editnode
Additionally, the following dependencies have been updated:
ag-grid-community: from 32.0.0 to 32.0.2
ag-grid-react: from 31.3.2 to 32.0.2
These changes address various issues and improve the overall stability and functionality of the code.