Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl a not working on edit node table #2992

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes several fixes and updates to the codebase. The changes include:

  • Removed console log and fixed nulland

  • Fixed ag grid version mismatch

  • Fixed unused import

  • Fixed ctrl+a not working on edit node and tweaks

  • Fixed styling on editnode

Additionally, the following dependencies have been updated:

  • ag-grid-community: from 32.0.0 to 32.0.2

  • ag-grid-react: from 31.3.2 to 32.0.2

These changes address various issues and improve the overall stability and functionality of the code.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 26, 2024
@lucaseduoli lucaseduoli self-assigned this Jul 26, 2024
@dosubot dosubot bot added the bug Something isn't working label Jul 26, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 26, 2024 17:27
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 26 Jul 24 17:28 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 26, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2992.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli linked an issue Jul 26, 2024 that may be closed by this pull request
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2024
@lucaseduoli lucaseduoli merged commit f7ad36b into main Jul 26, 2024
49 checks passed
@lucaseduoli lucaseduoli deleted the fix/ctrl_a_edit_node branch July 26, 2024 19:21
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* removed console log and fixed nulland

* Fixed ag grid version mismatch

* Fixed unused import

* Fixed ctrl+a not working on edit node and tweaks

* Fixed styling on editnode

* Made it work on mac

* ✅ (generalBugs-shard-7.spec.ts): add end-to-end test for selecting all with ctrl + A on advanced modal to ensure functionality works as expected

---------

Co-authored-by: cristhianzl <[email protected]>
(cherry picked from commit f7ad36b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+A not working on Advanced node modal
2 participants