Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment variable initialization issue #2971

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

italojohnny
Copy link
Member

This PR makes the following changes:

  • Change SettingsServiceFactory to use the Singleton pattern.
  • Remove code that overrides environment variables.

resolve #2717

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 26, 2024
@dosubot dosubot bot added the bug Something isn't working label Jul 26, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2971.dmtpw4p5recq1.amplifyapp.com

@rodgermoore
Copy link

🥇 Waiting for this one.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2024
@nicoloboschi nicoloboschi enabled auto-merge (squash) July 26, 2024 13:23
@nicoloboschi nicoloboschi mentioned this pull request Jul 26, 2024
3 tasks
@nicoloboschi nicoloboschi merged commit 169664c into main Jul 26, 2024
57 of 58 checks passed
@nicoloboschi nicoloboschi deleted the fix/init_env branch July 26, 2024 13:39
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* feat: apply singleton pattern to class

* fix: remove code that overrides environment vars

* feat: remove unused imports

(cherry picked from commit 169664c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

langflow unable to initialize variables from .env file
3 participants