Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videos not showing on docs #2967

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: videos not showing on docs #2967

merged 1 commit into from
Jul 25, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request fixes the issue where videos were not showing on the documentation page. The problem was caused by a missing configuration in the code. This PR adds the necessary configuration to ensure that videos are displayed correctly.

@lucaseduoli lucaseduoli self-assigned this Jul 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 25, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 25, 2024 20:35
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2967.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 25 Jul 24 20:43 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 25, 2024
@lucaseduoli lucaseduoli merged commit b2e40ec into main Jul 25, 2024
18 of 26 checks passed
@lucaseduoli lucaseduoli deleted the fix/docs_embedded_videos branch July 25, 2024 22:11
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
Fixed videos not showing on docs

(cherry picked from commit b2e40ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video not showing up on docs
2 participants