Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom value on dropown ui #2961

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

This pull request adds fuzzy search functionality and a custom value option to the Dropdown Component. The fuzzy search allows users to easily find options by typing a partial or misspelled value. The custom value option allows users to enter a value that is not present in the predefined options. These enhancements improve the usability and flexibility of the Dropdown Component.

@lucaseduoli lucaseduoli self-assigned this Jul 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jul 25, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 25 Jul 24 19:13 UTC

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 25, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2961.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli enabled auto-merge (squash) July 25, 2024 19:25
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 25, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) July 25, 2024 21:26
@lucaseduoli lucaseduoli merged commit 6a482f3 into main Jul 25, 2024
31 checks passed
@lucaseduoli lucaseduoli deleted the feature/dropdown_custom_value branch July 25, 2024 21:38
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* Added fuzzy search and custom value on search on Dropdown Component

* added allowCustom prop to allow custom values on dropdownComponent

* changed type of allowCustom

* added custom to custom field on dropdown

* Fixed empty search not showing all of the options

* Added Text on the left of the label

(cherry picked from commit 6a482f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants