Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate params assignment in custom_component_update endpoint #2931

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request refactors the params assignment in the custom_component_update endpoint by using a dictionary comprehension. This simplifies the code and improves readability.

Update input and output definitions for RunFlowComponent

Simplify the params assignment in the custom_component_update endpoint by using a dictionary comprehension. This improves code readability and reduces the number of lines.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 24, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 24, 2024 20:58
@dosubot dosubot bot added the python Pull requests that update Python code label Jul 24, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 24 Jul 24 20:58 UTC

@github-actions github-actions bot added the bug Something isn't working label Jul 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2931.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@ogabrielluiz ogabrielluiz merged commit 7d5ccb3 into main Jul 25, 2024
50 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/runflow branch July 25, 2024 00:33
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
…angflow-ai#2931)

* feat(RunFlow.py): update input and output definitions for RunFlowComponent

* refactor: update params assignment in custom_component_update endpoint

Simplify the params assignment in the custom_component_update endpoint by using a dictionary comprehension. This improves code readability and reduces the number of lines.

* feat(custom_component.py, flow.py): add support for specifying output type in run_flow method to filter outputs based on type

(cherry picked from commit 7d5ccb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants